[PATCH] D47162: [WebAssembly] Initial support for LTO

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

I think this needs a couple more tests:

- Test that the binding is copied correctly to the LLD symbol. You can probably do this with a test that shows that strong/weak resolution produces the correct symbol.
- Test that `VisibleToRegularObj` is set correctly when building an executable. See `test/ELF/lto/internalize-basic.ll` for an example.



================
Comment at: ELF/Options.td:200
 
-def lto_O: J<"lto-O">, MetaVarName<"<opt-level>">,
-  HelpText<"Optimization level for LTO">;
----------------
You probably want to undo this part or do it separately.


================
Comment at: test/wasm/lto/thinlto.ll:18
+; Then check without --thinlto-jobs (which currently default to hardware_concurrency)
+; We just check that we don't crash or fail (as it's not sure which tests are
+; stable on the final output file itself.
----------------
You should be able to do the same test here as in the other cases. I've updated this test in the ELF linker to do the same in r333480.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47162