[PATCH] D47500: [WebAssembly] Add support for response file parsing

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 29 16:10:09 PDT 2018


ruiu added inline comments.


================
Comment at: wasm/Options.td:76-77
 
+defm rsp_quoting: Eq<"rsp-quoting">,
+  HelpText<"Quoting style for response files. Values supported: windows|posix">;
+
----------------
Do you really need to support both Windows and Unix-style quoting rules? IMO Windows' quoting rule is pretty hairly, and you should always use Unix-style quoting rule if possible. Since you are the only generator who create response files, you can just create response files in Unix style, no?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47500





More information about the llvm-commits mailing list