[PATCH] D44598: [lit] Report line number for failed RUN command

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 29 13:31:12 PDT 2018


jdenny added a comment.

In https://reviews.llvm.org/D44598#1115242, @delcypher wrote:

> In https://reviews.llvm.org/D44598#1115233, @jdenny wrote:
>
> > In https://reviews.llvm.org/D44598#1115229, @lebedev.ri wrote:
> >
> > > In https://reviews.llvm.org/D44598#1115221, @jdenny wrote:
> > >
> > > > Ping.
> > >
> > >
> > > What seems to be the problem?
> > >  This was accepted before, reverted due to windows bot breakage,
> > >  https://reviews.llvm.org/D44598#1091098 suggests that breakage is fixed.
> > >  Just commit again?
> >
> >
> > There was enough of a code change that I thought the reviewer would want to take another look.  Is that not the right approach?
>
>
> A high level question. Why are we even testing using `cmd.exe` with an external shell? IIRC that's not a use case LLVM uses for Windows. Instead
>  the internal shell is used on Windows. Is this (`cmd.exe` as an external shell) really something we want to support? I don't see anything desirable about supporting `cmd.exe` as an
>  external shell because that means it can be very easy to write non-portable shell tests.


I'm not a windows developer.  I fixed that because others reverted my patch when it broke windows buildbots.  Someone else will have to answer.  Here's the bugzilla, in case that helps:

https://bugs.llvm.org/show_bug.cgi?id=37239


Repository:
  rL LLVM

https://reviews.llvm.org/D44598





More information about the llvm-commits mailing list