[PATCH] D47493: [llvm-objdump] Add -R option

Paul Semel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 29 13:05:59 PDT 2018


paulsemel added inline comments.


================
Comment at: include/llvm/Object/ELFObjectFile.h:795
 uint64_t ELFObjectFile<ELFT>::getRelocationOffset(DataRefImpl Rel) const {
-  assert(EF.getHeader()->e_type == ELF::ET_REL &&
-         "Only relocatable object files have relocation offsets");
----------------
I guess this assert was not here for no reason. But I didn't understand why we were forbidding this function for ELF files other than ET_REL.. Can someone explain me those lines ?


Repository:
  rL LLVM

https://reviews.llvm.org/D47493





More information about the llvm-commits mailing list