[PATCH] D47422: Set ADDE/ADDC/SUBE/SUBC to expand by default

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 29 11:07:19 PDT 2018


efriedma added a comment.

This could be potentially nasty for someone maintaining an out-of-tree backend; needs to be noted in the release notes and announced on llvmdev.

I'm not sure it's fair to say ADDC/ADDE are deprecated; I mean, yes, x86 has used ADDCARRY for a long time, but most in-tree backends don't, and the lack of glue makes lowering more complicated.  But I think this makes sense anyway; operations which aren't consistently available across most targets, like this, shouldn't default to Legal.


Repository:
  rL LLVM

https://reviews.llvm.org/D47422





More information about the llvm-commits mailing list