[PATCH] D47479: Add support for Hexagon

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Hi Sid,

Thank you for working on this! However, I'm not very happy to see a single large patch that adds large amount of code at once. It looks like the test doesn't test all the features and relocations you added in this patch, and it looks like the code is written in a pretty different way than those for other targets. It needs to be updated so that it is written in the same style as others. Discussing based on this large patch is perhaps not desirable.

What I'd like to see as a starter is the code that can only link an empty program that doesn't do anything. Could you reduce this patch to that absolute minimal one? After that we can start discussing details.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47479