[PATCH] D47414: [llvm-objcopy] Fix null symbol handling

[Paul Semel via Phabricator via llvm-commits]

paulsemel added a comment.

Hi!

I understand your point but still, there is smth that I don't get. Why would a user need to access the null symbol ? I see two different things :

- For reading. This is useless, this is just all zeros right, it makes no sense to read it.
- For writing. This is forbidden, we might never change the null symbol.

So, if we let the user play with it, that means we might add complexity while writing the new binary, to make sure the user didn't touched this symbol.
Can you elaborate more on the benefit to let the user access this symbol ?

The fact is that I find the way of changing the different functions that are using the SymbolTable not to touch the null symbol way more hacky than the current way (which is also hacky I admit it).


Repository:
  rL LLVM

https://reviews.llvm.org/D47414