[PATCH] D44897: [PowerPC] Do not emit record-form rotates when record-form andi/andis suffices

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 28 21:30:23 PDT 2018


nemanjai marked an inline comment as done.
nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:1912
+      // same halfword.
+      int MBInHWord = MB >= 16 ? 1 : 0;
+      int MEInHWord = ME >= 16 ? 1 : 0;
----------------
inouehrs wrote:
> MBInLoHWord/MEInLoHWord are more descriptive. I first think H means Hi before reading comment.
> Also they can be bool, but it is ok if you prefer int for bool.
> 
Thanks, that's a good idea.


Repository:
  rL LLVM

https://reviews.llvm.org/D44897





More information about the llvm-commits mailing list