[PATCH] D47108: [CodeGenCXX] Add -fforce-emit-vtables

[Krzysztof Pszeniczny via Phabricator via llvm-commits]

amharc requested changes to this revision.
amharc added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/test/CodeGenCXX/vtable-available-externally.cpp:445
+// after the Derived construction.
+// CHECK-FORCE-EMIT-DAG: @_ZTVN6Test187DerivedE = linkonce_odr unnamed_addr constant {{.*}} @_ZTIN6Test187DerivedE {{.*}} @_ZN6Test184Base3funEv {{.*}} @_ZN6Test187DerivedD1Ev {{.*}} @_ZN6Test187DerivedD0Ev
+// CHECK-FORCE-EMIT-DAG: define linkonce_odr void @_ZN6Test187DerivedD0Ev
----------------
This still uses `_ZN6Test187DerivedD1Ev` instead of `_ZN6Test184BaseD2Ev`, because the triple you selected is `x86_64-apple-darwin10` and `-mconstructor-aliases` is off by default on Darwin.

I suggest you either add `-mconstructor-aliases` to the compiler invocation or change the triple to literally everything else than Darwin (or CUDA). Preferably the former, as it shows clearly what we want to test here.


Repository:
  rL LLVM

https://reviews.llvm.org/D47108