[PATCH] D47385: [Polly][ForwardOpTree] Use less computationally expensive method to compute def-to-target map. NFCI.

Tobias Grosser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 27 23:22:28 PDT 2018


grosser added a comment.

Hi Michael,

this looks very good. I am especially interested in further optimizations for cases where the original schedule has not been changed. (What is the case currently in Polly). Just some minor nits:

"to this" -> "do this"



================
Comment at: lib/Transform/ForwardOpTree.cpp:409
+  /// moved to TargetStmt. To be generally correct, we also need to know all the
+  /// intermediate statement. However, we make use of the fact that we currently
+  /// do not support a move from a loop body accross its header such that only
----------------
statements.


================
Comment at: lib/Transform/ForwardOpTree.cpp:410
+  /// intermediate statement. However, we make use of the fact that we currently
+  /// do not support a move from a loop body accross its header such that only
+  /// the first definition and the target statement are relevant.
----------------
across


Repository:
  rPLO Polly

https://reviews.llvm.org/D47385





More information about the llvm-commits mailing list