[PATCH] D47436: [llvm-c] Remove LLVMAddBBVectorizePass

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: hfinkel, chandlerc.
Herald added a reviewer: whitequark.
Herald added a reviewer: deadalnix.
Herald added a subscriber: llvm-commits.

It was fully replaced back in 2014, and the implementation was removed 11 months ago by r306797.


Repository:
  rL LLVM

https://reviews.llvm.org/D47436

Files:
  bindings/ocaml/transforms/vectorize/llvm_vectorize.mli
  bindings/ocaml/transforms/vectorize/vectorize_ocaml.c
  docs/ReleaseNotes.rst
  include/llvm-c/Transforms/Vectorize.h
  lib/Transforms/Vectorize/Vectorize.cpp


Index: lib/Transforms/Vectorize/Vectorize.cpp
===================================================================
--- lib/Transforms/Vectorize/Vectorize.cpp
+++ lib/Transforms/Vectorize/Vectorize.cpp
@@ -34,10 +34,6 @@
   initializeVectorization(*unwrap(R));
 }
 
-// DEPRECATED: Remove after the LLVM 5 release.
-void LLVMAddBBVectorizePass(LLVMPassManagerRef PM) {
-}
-
 void LLVMAddLoopVectorizePass(LLVMPassManagerRef PM) {
   unwrap(PM)->add(createLoopVectorizePass());
 }
Index: include/llvm-c/Transforms/Vectorize.h
===================================================================
--- include/llvm-c/Transforms/Vectorize.h
+++ include/llvm-c/Transforms/Vectorize.h
@@ -33,9 +33,6 @@
  * @{
  */
 
-/** DEPRECATED - Use LLVMAddSLPVectorizePass */
-void LLVMAddBBVectorizePass(LLVMPassManagerRef PM);
-
 /** See llvm::createLoopVectorizePass function. */
 void LLVMAddLoopVectorizePass(LLVMPassManagerRef PM);
 
Index: docs/ReleaseNotes.rst
===================================================================
--- docs/ReleaseNotes.rst
+++ docs/ReleaseNotes.rst
@@ -146,13 +146,15 @@
 Changes to the OCaml bindings
 -----------------------------
 
- During this release ...
+* Remove ``add_bb_vectorize``.
 
 
 Changes to the C API
 --------------------
 
- During this release ...
+* Remove ``LLVMAddBBVectorizePass``. The implementation was removed and the C
+  interface was made a deprecated no-op in LLVM 5. Use
+  ``LLVMAddSLPVectorizePass`` instead to get the supported SLP vectorizer.
 
 
 External Open Source Projects Using LLVM 7
Index: bindings/ocaml/transforms/vectorize/vectorize_ocaml.c
===================================================================
--- bindings/ocaml/transforms/vectorize/vectorize_ocaml.c
+++ bindings/ocaml/transforms/vectorize/vectorize_ocaml.c
@@ -19,12 +19,6 @@
 #include "caml/mlvalues.h"
 #include "caml/misc.h"
 
-/* [<Llvm.PassManager.any] Llvm.PassManager.t -> unit */
-CAMLprim value llvm_add_bb_vectorize(LLVMPassManagerRef PM) {
-  LLVMAddBBVectorizePass(PM);
-  return Val_unit;
-}
-
 /* [<Llvm.PassManager.any] Llvm.PassManager.t -> unit */
 CAMLprim value llvm_add_loop_vectorize(LLVMPassManagerRef PM) {
   LLVMAddLoopVectorizePass(PM);
Index: bindings/ocaml/transforms/vectorize/llvm_vectorize.mli
===================================================================
--- bindings/ocaml/transforms/vectorize/llvm_vectorize.mli
+++ bindings/ocaml/transforms/vectorize/llvm_vectorize.mli
@@ -12,11 +12,6 @@
     This interface provides an OCaml API for LLVM vectorize transforms, the
     classes in the [LLVMVectorize] library. *)
 
-(** See the [llvm::createBBVectorizePass] function. *)
-external add_bb_vectorize
-  : [<Llvm.PassManager.any] Llvm.PassManager.t -> unit
-  = "llvm_add_bb_vectorize"
-
 (** See the [llvm::createLoopVectorizePass] function. *)
 external add_loop_vectorize
   : [<Llvm.PassManager.any] Llvm.PassManager.t -> unit


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47436.148773.patch
Type: text/x-patch
Size: 2906 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180527/6064e385/attachment.bin>