[PATCH] D47098: [ELF] Make R_GOTONLY_PC_FROM_END R_GOTREL_FROM_END relative to _GLOBAL_OFFSET_TABLE_ instead of end of .got

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

> Also, you are creating "relocation" folder for the new test. Please do not do it, just place the test near our others tests we have for the relocations.
>  (If you think it is worth to add a new folder for relocations it should be in a separate review and/or discussed first. I probably would not do that, btw).

Thank you for noticing this. I didn't notice when I review this patch. I'll move that file to the parent directory.

Fangrui,

Please follow the local convention whenever possible, and if you have to do something new, please mention that in the patch description. That helps reviewers a lot. Thanks!


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47098