[PATCH] D47371: [BPI] Apply invoke heuristic before loop branch heuristic

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Thanks for the patch. Full disclaimer: I don't have much knowledge about this part of the codebase.

I've noticed that calcUnreachableHeuristics and calcColdCallHeuristics both avoid work when the terminator is an invoke. Do you think it would make more sense to handle invokes first, and to then assert that invokes aren't seen in the other heuristics? IMO it would reduce the amount of special-casing needed.


Repository:
  rL LLVM

https://reviews.llvm.org/D47371