[PATCH] D47306: [llvm-mca] Register listeners with the Stage instances.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 25 09:11:33 PDT 2018


mattd added a comment.

In https://reviews.llvm.org/D47306#1112268, @andreadb wrote:

> Hi Matt,
>
> This patch looks good. However, the code will have to change again once the RetireStage and the ExecuteStage are available.
>
> So, if you don't mind, I think it is better if we keep this patch on hold for now.
>  Today, I have reviewed (and accepted) the patch that introduces the RetireStage.
>  Once we have the ExecuteStage, then we can revisit this patch. What do you think?


I completely agree.


https://reviews.llvm.org/D47306





More information about the llvm-commits mailing list