[PATCH] D45150: Less conservative LoopSafetyInfo for headers

Piotr Padlewski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 25 04:26:58 PDT 2018


Prazek added a comment.

OK, so it seems that at least the tests in the second patch passes without this patch, so I am fine with committing it without this one for one (also Philip if you could take a look at that patch I would be grateful)
I am worried about cases, where the first instruction does not throw, but it we can't hoist it (e.g. it depends on the loop phi) and after that, there is an instruction that can be hoisted.

Right now we bail out if we reach more than 66 instructions. Is there a lower number that is greater than 1 that you think would be small enough to slow down the compilation imperceptibly, like 10?


Repository:
  rL LLVM

https://reviews.llvm.org/D45150





More information about the llvm-commits mailing list