[PATCH] D47153: [Support] Avoid normalization in sys::getDefaultTargetTriple

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 24 20:15:14 PDT 2018


phosek added a comment.

In https://reviews.llvm.org/D47153#1111541, @rnk wrote:

> I think we can probably split this patch up to reduce the risk of breaking things. I think if you revert the config-ix.cmake change and just move triple normalization from LLVM to clang, everything should keep working. LLVM tools like llc might start to break in interesting ways, though, since they won't do the normalization that clang is doing. If `check-llvm` passes, though, I'm happy.
>
> The config-ix.cmake and %itanium_abi_triple can be a follow-up.


All the tests seem to be passing now, but the patch is rather large now. I tried splitting up the the triple normalization and everything seems to be still passing so I'm fine landing those two parts separately.


Repository:
  rL LLVM

https://reviews.llvm.org/D47153





More information about the llvm-commits mailing list