[PATCH] D47237: [DSE] Calloc-strlen optimizations

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 24 17:42:40 PDT 2018


xbolva00 added inline comments.


================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:581
+                                       Instruction *SecondI, AliasAnalysis *AA,
+                                       const Value *Op = nullptr) {
+  if (FirstI == SecondI)
----------------
efriedma wrote:
> Can you just make the MemoryLocation a parameter here?  I don't think your changes to MemoryLocation.h are useful.
Good point! Thanks.


https://reviews.llvm.org/D47237





More information about the llvm-commits mailing list