[PATCH] D46896: [llvm-objcopy] Add --strip-unneeded option

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 24 15:14:51 PDT 2018


jakehehrlich accepted this revision.
jakehehrlich added a comment.

nit: Add comment above loop but otherwise LGTM. Feel free to submit after that.



================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:267
 
+    if (Config.StripUnneeded) {
+      for (auto &Section : Obj.sections())
----------------
nit: If you could add a comment explaining what this is doing and why it needs to be here that would be great.


Repository:
  rL LLVM

https://reviews.llvm.org/D46896





More information about the llvm-commits mailing list