[PATCH] D47330: [DAGCombiner] match vector compare and select sizes with extload operand (PR37427)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D47330#1111518, @spatel wrote:

> Patch updated:
>  Use isLoadExtLegalOrCustom() to check if the load is allowed. This means less diffs for AVX1 because it has a smaller set of extending loads than AVX2.
>
> I need to step back through some of these tests and see if the earlier rev of the patch was miscompiling or just producing weird sequences.


I think the AVX1 changes in the old rev were actually improvements; what we see here now (ie, AVX1 unchanged tests, so either with or without this patch), is worse. But I'll just make that another potential follow-up. Hopefully, now I'm checking the extload availability correctly, so there won't be as many oddities to investigate all at once.


https://reviews.llvm.org/D47330