[PATCH] D47339: [GVN,NewGVN] Propagate nonnull if K dominates J.

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added a comment.

This assertion must hold for all replacements independent of this patch, because it would be invalid SSA otherwise.
I don't think the assertion is worth it given that.
The only case that is not true is when you are replacing into a phi node in a successor block (and there it is legal because it dominates that edge, even if it does not dominate the phi node).
Your assertion also would not catch this case.

Past that, I assume this works in the memory models being laid out by Nuno, Sanjoy, et al, but adding Nuno to verify.


https://reviews.llvm.org/D47339