[PATCH] D46315: [RegUsageInfoCollector] Fix handling of callee saved registers with CSR optimization.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

LGTM.

Up to you for the logging. We can keep it.

There's one nit in the test case you didn't address about getting rid of the implicit variables + one blocking problem: the test requires asserts.



================
Comment at: test/CodeGen/SystemZ/ipra-04.ll:8
+; DBG: fun1 function optimized for not having CSR
+; DBG: Call Instruction After Register Usage Info Propagation : CallBRASL @fun1{{.*}} $r14d $r15d
+
----------------
You'll need an assert build if you want to look at the log.

I.e., REQUIRE: asserts (or something like that :P).


https://reviews.llvm.org/D46315