[PATCH] D47248: [demangler] Add ItaniumPartialDemangler::isCtorOrDtor

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 2 inline comments as done.
MaskRay added inline comments.


================
Comment at: lib/Demangle/ItaniumDemangle.cpp:5271
+  while (N) {
+    switch (N->getKind()) {
+    default:
----------------
erik.pilkington wrote:
> No reason to include DtorName or QualifiedName, those can only appear in expressions (via an <unresolved-name>) so they should be unreachable. 
Done.

Thanks. I see, these cases are covered by `getFunctionBaseName` above.


Repository:
  rL LLVM

https://reviews.llvm.org/D47248