[PATCH] D47153: [Support] Avoid normalization in sys::getDefaultTargetTriple

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 23 14:51:42 PDT 2018


phosek added inline comments.


================
Comment at: llvm/utils/lit/lit/llvm/config.py:252
         os = m.group(3).lower()
-        if os == 'win32':
-            # If the OS is win32, we're done.
+        if os == 'windows':
+            # If the OS is windows, we're done.
----------------
@rnk I assume this should only be the case when the triple is `*-windows-msvc`, not `*-windows-gnu`, but what if user omits the environment? Shall we just bail out or pick some default?


Repository:
  rL LLVM

https://reviews.llvm.org/D47153





More information about the llvm-commits mailing list