[PATCH] D47279: DAG: Remove redundant version of getRegisterTypeForCallingConv

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 23 13:27:42 PDT 2018


arsenm created this revision.
arsenm added a reviewer: bogner.
Herald added subscribers: atanasyan, arichardson, wdng, sdardis.

There seems to be no real reason to have these separate copies.
The existing implementations just copy each other for x86.
For Mips there is a subtle difference, which is just a bug
since it changes based on the context where which one was called.
Dropping this version, all tests pass. If I try to merge them
to match the removed version, a test fails.


https://reviews.llvm.org/D47279

Files:
  include/llvm/CodeGen/TargetLowering.h
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  lib/Target/Mips/MipsISelLowering.cpp
  lib/Target/Mips/MipsISelLowering.h
  lib/Target/X86/X86ISelLowering.cpp
  lib/Target/X86/X86ISelLowering.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47279.148276.patch
Type: text/x-patch
Size: 4533 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180523/f1fe1610/attachment.bin>


More information about the llvm-commits mailing list