[PATCH] D47263: [dwarfdump] Have -c and -p work together

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:478
   if (DumpOpts.ShowParents) {
-    DumpOpts.ShowParents = false;
-    Indent = dumpParentChain(getParent(), OS, Indent, DumpOpts);
+    DIDumpOptions NewDumpOpts = DumpOpts;
+    NewDumpOpts.ShowParents = false;
----------------
perhaps call them `ParentDumpOpts`?


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:479
+    DIDumpOptions NewDumpOpts = DumpOpts;
+    NewDumpOpts.ShowParents = false;
+    NewDumpOpts.ShowChildren = false;
----------------
This looks unintuitive: Does dumpParentChain print all parents?


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:515
           DumpOpts.RecurseDepth--;
+          DIDumpOptions NewDumpOpts = DumpOpts;
+          NewDumpOpts.ShowParents = false;
----------------
`ChildDumpOpts`


Repository:
  rL LLVM

https://reviews.llvm.org/D47263