[PATCH] D46967: Vector constrained FP intrinsics

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

In https://reviews.llvm.org/D46967#1108432, @cameron.mcinally wrote:

> Oh, interesting. So the second comment on https://reviews.llvm.org/D45576 suggests that there's more design for this than I've seen so far. I'll close this Diff, if there are not objections. It's pretty clear that this is not the correct path going forward.


On the other hand, the problem you've noticed here is of course still real, and needs to be addressed one way or the other.   It looks like we will have to have support for properly legalizing STRICT_ operations on unsupported (vector) types.  This isn't really addressed by my patch either.  (I didn't even realize there was a problem; I had not looked a STRICT operations on vector types at all so far.)

> Ulrich, is there support I can provide you without stepping on your toes? Maybe I could write tests to exercise the intrinsics? Or something else?

If you still want to go ahead and implement legalization along the lines of your previous comment ("The splitting and expanding code needs to be taught how to handle the chain on constrained operations."), that wouldn't be stepping on my toes at all :-)


Repository:
  rL LLVM

https://reviews.llvm.org/D46967