[PATCH] D45181: [RISCV] Add diff relocation support for RISC-V

[Alex Bradbury via Phabricator via llvm-commits]

asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

Thanks Simon. A few minor nitpicks, but this looks good to me.

You forgot to include full context in the updated patch version.



================
Comment at: include/llvm/MC/MCFixup.h:112
+
+  /// \brief Return a fixup corresponding to the sub half of a add/sub fixup
+  /// pair for the given Fixup.
----------------
This \brief still needs removing


================
Comment at: lib/MC/MCAssembler.cpp:739-740
+                                   FixedValue);
+    }
+    else {
+      getWriter().recordRelocation(*this, Layout, &F, Fixup, Target,
----------------
Should be on a single line `} else {`


================
Comment at: lib/MC/MCExpr.cpp:583
+  // the InSet flag is set to get the current difference anyway (used for
+  // example to calculate symbol sizes)
+  if (Asm &&
----------------
reloations -> relocations

Nitpick: end with full stop


Repository:
  rL LLVM

https://reviews.llvm.org/D45181