[PATCH] D46874: [MC] - Add .stack_size sections into groups and link them with .text

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In https://reviews.llvm.org/D46874#1109198, @grimar wrote:

> And observing the results, I think it is worth to stop doing unification when -ffunction-sections is off
>  (to reduce the number of sections and possible linker slowdown).
>
> I'll update the patch.


I agree, although with one caveat: COMDAT sections should always have a separate .stack_sizes section (maybe in their group), as otherwise we'll have the same invalid problem for discarded COMDATs as I mentioned earlier - i.e. their entries will be preserved, even though they are no longer present.


https://reviews.llvm.org/D46874