[PATCH] D46789: [StackProtector] Don't crash when passing post-SP IR back in

[Tim Shen via Phabricator via llvm-commits]

timshen added a comment.

My feeling is that getSDagStackGuard/getSSPStackGuardCheck gets mismatched with shouldEmitSDCheck/SupportsSelectionDAGSP. Would you explain the invariance between them if you already investigated it? It seems shouldEmitSDCheck needs to be fixed too, but the current patch doesn't fix it.

Also, the function getSSPStackGuardCheck is weird, since we already have getSDagStackGuard.


Repository:
  rL LLVM

https://reviews.llvm.org/D46789