[PATCH] D47204: [WebAssembly] Properly calculate function body offset, and write I32 values.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 22 13:42:50 PDT 2018


ruiu added a comment.

I'm not sure if I fully understand the problem, but don't you have a binary that didn't link correctly without this patch, no? I thought that you could reduce it to create a test.

As to the code that could be llvm_unreacahble, I think it should be llvm_unreacahble. If some path is not expected to run, we shouldn't write code for it.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47204





More information about the llvm-commits mailing list