[PATCH] D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type

[Zinovy Nis via Phabricator via llvm-commits]

zinovy.nis added inline comments.


================
Comment at: clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:198
   E = E->ignoreParenBaseCasts();
+  if (const auto *EC = dyn_cast<ExprWithCleanups>(E))
+    E = EC->getSubExpr();
----------------
malcolm.parsons wrote:
> `E->IgnoreImplicit()` can be used to ignore `ExprWithCleanups`
Thanks. But it seems to be too agressive:


```
return (i & 1) != 0;
```

becomes 

```
return static_cast<bool>(i & 1);
```



Repository:
  rL LLVM

https://reviews.llvm.org/D47122