[PATCH] D41574: [Transforms] Adding a WeakReassociate pass

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 22 10:13:18 PDT 2018


lebedev.ri added inline comments.


================
Comment at: lib/Transforms/Scalar/WeakReassociate.cpp:103
+    return false;
+  return LHS.Op1->getValue().slt(RHS.Op1->getValue());
+}
----------------
It is hopefully nothing, but what if they compare equal?
I'm basically thinking about the `llvm::sort()` being intentionally unstable kind of things.


Repository:
  rL LLVM

https://reviews.llvm.org/D41574





More information about the llvm-commits mailing list