[PATCH] D47162: [WebAssembly] Initial support for LTO

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 22 10:01:11 PDT 2018


sbc100 added inline comments.


================
Comment at: wasm/InputFiles.cpp:392
+  if (T.getArch() != Triple::wasm32) {
+    fatal(toString(MB.getBufferIdentifier()) + ": machine type must be wasm32");
+    return;
----------------
ruiu wrote:
> ruiu wrote:
> > `fatal` is to report corrupted files. Since this case is to report a miseuse of the command, you should use `error`.
> Please fix.
Both COFF and ELF use fatal() when when passed bitcode of the wrong arch, but I guess that just means that they need fixing.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47162





More information about the llvm-commits mailing list