[PATCH] D46896: [llvm-objcopy] Add --strip-unneeded option

Jake Ehrlich via llvm-commits llvm-commits at lists.llvm.org
Tue May 22 09:50:11 PDT 2018


Just a heads up I'm not convinced my shared_ptr idea is ok. I want to
consider what Alex and James are saying. My hope has always been to keep
the symbol table as the owner so if Alex has a proposal I want to read it
first.

On Tue, May 22, 2018, 9:39 AM Paul Semel via Phabricator <
reviews at reviews.llvm.org> wrote:

> paulsemel added a comment.
>
> Ok, I've a working version with `shared_ptr` (I should have checked my
> emails before going on the implementation :) ). What should we do ?
> If we go for the new section interface, we should probably introduce it in
> a separate patch, right ?
> Do I still update this patch with the `shared_ptr` waiting for a better
> implementation ?
> If you guys don't have time to do it, I can try if you want (maybe I'll
> need a bit more explanation about what you have in mind :) )
>
> cc: @jakehehrlich @jhenderson @alexshap
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D46896
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180522/31f5d04a/attachment.html>


More information about the llvm-commits mailing list