[PATCH] D47188: Intel SVML calling conventions

[Denis Nagorny via Phabricator via llvm-commits]

dvnagorny added inline comments.


================
Comment at: include/llvm/IR/SVML.td:53
+// While SVML doesn't provide _ha versions of
+// the following symbols let's disable their vectorization.
+
----------------
hfinkel wrote:
> dvnagorny wrote:
> > hfinkel wrote:
> > > What does this mean? Why would a _ha variant of floor, for example, be needed for vectorization? Or, to put it another way, how would a _ha variant of floor differ from the _ep version?
> > Really I don't expect any difference in behaviour, However I think that link-time weak aliases for these symbols are more preferable here. It will not require any additional logic in function name mangling code.
> >  
> Do these aliases exist currently? I'm concerned about the comment saying that we're disabling vectorization of floor, etc., and I'm prefer that we not disable vectorization unnecessarily.
Really this code will work when vector-library SVML option will be explicitly passed. So it doesn't disable any default vectorizations. On the other hand in the current LLVM state these function's vectorization isn't enabled yet. So I keep their vectorization the same. From SVML library side aliases aren't available yet however this library not the only potential source of aliases. 
It's quite simple to provide them from the application code.


Repository:
  rL LLVM

https://reviews.llvm.org/D47188