[PATCH] D47141: [x86] invpcid LLVM intrinsic

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: test/CodeGen/X86/invpcid-intrinsic.ll:16
+; X86_64-NEXT:    # kill: def $edi killed $edi def $rdi
+; X86_64-NEXT:    invpcid (%rsi), %rdi
+; X86_64-NEXT:    retq
----------------
This shows the bug I mentioned above, rdi needs to be zero extended from edi.


================
Comment at: test/CodeGen/X86/invpcid-intrinsic.ll:38
+entry:
+  %0 = load i32, i32* %type, align 4
+  tail call void @llvm.x86.invpcid(i32 %0, i8* %descriptor) #1
----------------
GBuella wrote:
> craig.topper wrote:
> > Why are you testing with a load for type, but not testing without a load?
> There is a test without a load above this one.
I have no idea how I missed that. Maybe I scrolled down too far.


Repository:
  rL LLVM

https://reviews.llvm.org/D47141