[PATCH] D47188: Intel SVML calling conventions

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: include/llvm/Analysis/TargetLibraryInfo.h:159
   bool isFunctionVectorizable(StringRef F, unsigned VF) const {
-    return !getVectorizedFunction(F, VF).empty();
+     bool IgnoreMeThere;
+     return !getVectorizedFunction(F, VF, IgnoreMeThere, false).empty();
----------------
I think just "Ignored" is fine.


================
Comment at: include/llvm/IR/SVML.td:53
+// While SVML doesn't provide _ha versions of
+// the following symbols let's disable their vectorization.
+
----------------
What does this mean? Why would a _ha variant of floor, for example, be needed for vectorization? Or, to put it another way, how would a _ha variant of floor differ from the _ep version?


Repository:
  rL LLVM

https://reviews.llvm.org/D47188