[PATCH] D47188: Intel SVML calling conventions

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: include/llvm/IR/CallingConv.h:225
+    Intel_SVML = 97,
+    //
     /// The highest possible calling convention ID. Must be some 2^k - 1.
----------------
unneeded comment


================
Comment at: lib/Analysis/TargetLibraryInfo.cpp:55
+  std::string FullName = FnName;
+  return IsFast ? FullName : FullName + "_ha";
+}
----------------
This memory allocation looks unfortunate :/


================
Comment at: utils/TableGen/SVMLEmitter.cpp:63
+  for (const auto &D : Records.getDefs()) {
+    std::string SvmlVariantNameStr = D.first;
+    // Single Precision SVML
----------------
This surely can be `StringRef`


Repository:
  rL LLVM

https://reviews.llvm.org/D47188