[PATCH] D46992: [AMDGPU] Add perf hints to functions

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 15:10:30 PDT 2018


rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUPerfHintAnalysis.cpp:293
+
+  AMDGPUPerfHintAnalysis::FuncInfoMap::iterator Loc = FIM.find(&F);
+  assert(Loc != FIM.end() && "No func info");
----------------
arsenm wrote:
> Move this up to avoid calling the same find twice? visit can also return the inserted iterator
It is not the same, it is one after visit() call. But yes, changing to visit to return the iterator.


https://reviews.llvm.org/D46992





More information about the llvm-commits mailing list