[PATCH] D47167: Handle --plugin-opt= options as alias options.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 17:27:10 PDT 2018


pcc added inline comments.


================
Comment at: lld/ELF/DriverUtils.cpp:106
+      V.push_back(Saver.save(S + "=" + Args[I + 1]).data());
+      ++I;
+    } else {
----------------
I don't think this correctly handles the case where the last two arguments are `-plugin-opt foo`. Won't you end up with an out of bounds access?


https://reviews.llvm.org/D47167





More information about the llvm-commits mailing list