[PATCH] D47149: [SCCP] Mark DominatorTreeAnalysis as preserved.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 13:08:02 PDT 2018


davide added a comment.

Florian, I won't be opposed if you decide to preserve the dominator tree as part of `changeToUnreachable`, but, as we discussed with Dan in the past, do we really need to? I mean, we could just change `changeToUnreachable` (no pun intended) to do something sane and not modify the CFG (if the block is really unreachable, it's very likely that the next round of DCE is going to remove it anyway) [and in case it doesn't I'm really not worried about running DCE again because it's really basically free].


https://reviews.llvm.org/D47149





More information about the llvm-commits mailing list