[PATCH] D47124: [X86] Remove masking from vpternlog intrinsics. Use a select in IR instead.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - with a couple of (very) minors. Thanks.



================
Comment at: lib/IR/AutoUpgrade.cpp:2538
+      bool ZeroMask = Name[11] == 'z';
+      unsigned VecWidth = CI->getType()->getPrimitiveSizeInBits();
+      unsigned EltWidth = CI->getType()->getScalarSizeInBits();
----------------
Is it worth pulling out the CI->getType() repetitions?


================
Comment at: lib/IR/AutoUpgrade.cpp:2556
+
+      Value *Args[] = { CI->getArgOperand(0) , CI->getArgOperand(1),
+                        CI->getArgOperand(2), CI->getArgOperand(3) };
----------------
remove the space before the comma


https://reviews.llvm.org/D47124