[PATCH] D47051: MC: Introduce an ELF dwo object writer and teach llvm-mc about it.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 12:43:21 PDT 2018


pcc added inline comments.


================
Comment at: llvm/lib/MC/ELFObjectWriter.cpp:165
   ELFWriter(ELFObjectWriter &OWriter, raw_pwrite_stream &OS,
-            bool IsLittleEndian)
+            bool IsLittleEndian, DwoMode Mode)
       : OWriter(OWriter),
----------------
echristo wrote:
> It feels a little awkward to special case this for dwo files rather than just be a general object emitter. That said, generalization should be possible in the future.
That's true, but right now it feels premature to be generalizing this code, as there aren't enough users yet. Probably something to think about if/when we add another user.


https://reviews.llvm.org/D47051





More information about the llvm-commits mailing list