[PATCH] D47040: MC: Change object writers to use endian::Writer. NFCI.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 10:58:33 PDT 2018


pcc added inline comments.


================
Comment at: llvm/lib/MC/MCLinkerOptimizationHint.cpp:39
                           const MCAsmLayout &Layout) const {
-  raw_ostream &OutStream = ObjWriter.getStream();
+  raw_ostream &OutStream = ObjWriter.W.OS;
   emit_impl(OutStream, ObjWriter, Layout);
----------------
echristo wrote:
> FWIW this change feels a bit awkward. It's fine for now and I don't know if it's changed in a future patch. That said, it can easily be cleaned up later.
Yes, the whole way that LOH directives are handled seems a little odd and it may be better for it to mostly live in the Mach-O object writer. That seemed out of scope for the work that I was doing so I left it for now.


https://reviews.llvm.org/D47040





More information about the llvm-commits mailing list