[PATCH] D47117: [CVP][NFCI] Refactor truncated binary operator creation out of processUDivOrURem()

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 10:05:46 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D47117#1105974, @lebedev.ri wrote:

> In https://reviews.llvm.org/D47117#1105928, @spatel wrote:
>
> > It's fine as a clean-up, but would it be better still to use IRBuilder?
>
>
> I can certainly do that, but that will do constant propagation; do we want that here?


Hmm...not sure what the trade-off would be in that case. Do you have an example in mind?


Repository:
  rL LLVM

https://reviews.llvm.org/D47117





More information about the llvm-commits mailing list