[PATCH] D46528: [DAGCombine][X86][AArch64] Masked merge unfolding: vector edition.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon requested changes to this revision.
RKSimon added a comment.
This revision now requires changes to proceed.

I 'm happy with the illegal type tests to go in but the lost ANDNP combine could be a problem.



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:4776
+
+  // FIXME: MMX has 'pandn'
+
----------------
Its very unlikely we'll ever add MMX support to this - drop this FIXME.


================
Comment at: test/CodeGen/X86/unfold-masked-merge-vector-variablemask-const.ll:65
+; CHECK-SSE2-NEXT:    pand (%rdi), %xmm0
+; CHECK-SSE2-NEXT:    por %xmm1, %xmm0
 ; CHECK-SSE2-NEXT:    retq
----------------
This regression is rather unfortunate - anyway that we can get the X86ISD::ANDNP back?


Repository:
  rL LLVM

https://reviews.llvm.org/D46528