[PATCH] D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters

Robert Widmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 18 18:45:52 PDT 2018


CodaFi added a comment.

In https://reviews.llvm.org/D46890#1102616, @whitequark wrote:

> First, the naming here is absurdly confusing. Second, it's also inconsistent with all other functions, e.g. LLVMGetSourceFileName/LLVMSetSourceFileName.
>
> Use LLVMGetValueName2 and LLVMSetValueName2, since this is what we do when updating function signatures in the C API.


No problem.  I'll update the names.


Repository:
  rL LLVM

https://reviews.llvm.org/D46890





More information about the llvm-commits mailing list