[PATCH] D47082: Fix build warning compiling TestPlugin on Windows and disable Passes plugin stuff on Windows since it fundamentally can't work

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 18 14:01:14 PDT 2018


aaron.ballman added a comment.

In https://reviews.llvm.org/D47082#1105042, @philip.pfaffe wrote:

> There is this ancient commit here https://reviews.llvm.org/D18826 that introduced auto-export of all symbols. Shouldn't this work here as well?


Blech, yes, I believe it could, but I agree with @rnk's original comments on that thread -- we should consider getting serious about properly annotating our API boundaries. Obviously, that is not in scope for this patch. ;-)


https://reviews.llvm.org/D47082





More information about the llvm-commits mailing list