[llvm] r332664 - [codeview] Include record prefix in global type hashing

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri May 18 13:21:19 PDT 2018


Up to you, you can change it or not. I prefer to have a general idea of
what a test does by looking at the file name, but if you are ok with this
I’m fine
On Fri, May 18, 2018 at 10:47 AM Reid Kleckner <rnk at google.com> wrote:

> On Thu, May 17, 2018 at 3:17 PM Zachary Turner <zturner at google.com> wrote:
>
>> Do we usually name tests with names like pr12345?  Seems like we should
>> just give it a meaningful name like ghash-record-only-differs-by-prefix.test
>>
>
> Some people do. I usually do it when the situation I'm testing takes more
> than four words to describe or I just can't think of a good, meaningful
> test case name. pdb-ghash-record-prefix.ll maybe?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180518/2bf13a79/attachment.html>


More information about the llvm-commits mailing list