[PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

In https://reviews.llvm.org/D46889#1104882, @aemerson wrote:

> In https://reviews.llvm.org/D46889#1104823, @aprantl wrote:
>
> > Thanks for jumping on this Amara — I just wanted to point out that we ususally don't revert lldb changes that only break the lldb-xcode bot if they pass on the lldb-cmake bot at the same time. When this happens it usually means that the lldb Xcode project must be updated and it's too much to ask from all open source contributors to get access to a machine running Xcode to do this. Instead one of the Apple LLDB developers usually goes in and updates the Xcode project for them.
> >
> > - adrian
>
>
> Ah ok. Does that include cases like this one with the link error:
>
>   Undefined symbols for architecture x86_64:
>     "lldb_private::AppleDWARFIndex::Create(lldb_private::Module&, lldb_private::DWARFDataExtractor, lldb_private::DWARFDataExtractor, lldb_private::DWARFDataExtractor, lldb_private::DWARFDataExtractor, lldb_private::DWARFDataExtractor)", referenced from:
>         SymbolFileDWARF::InitializeObject() in liblldb-core.a(SymbolFileDWARF.o)
>     "vtable for lldb_private::ManualDWARFIndex", referenced from:
>         SymbolFileDWARF::InitializeObject() in liblldb-core.a(SymbolFileDWARF.o)
>     NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
>


A link error is the most common manifestation of a file not being added to the xcode project. the vtable in question would have been emitted if ManualDWARFIndex.cpp (created by this CL) was built with everything else.

I did verify that this patch builds (with cmake) and all tests pass on darwin, so I don't expect there to be any other problems.

I am going to try relanding this when I'm back at work on Monday, but until then, if someone knows how to add these files to the project, I'd appreciate it if he can submit those changes together with this patch, and we can avoid having the bot go red again.


Repository:
  rL LLVM

https://reviews.llvm.org/D46889